netdev - Re: [PATCH] e1000e: fix warn_on reload after phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 03:31:10 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] e1000e: fix warn_on reload after phy_id error

Jeff Kirsher wrote:
> If the driver fails to initialize the first time due to the failure in the
> phy_id check the kernel triggers a warn_on on the second try to load the
> driver because the driver did not free the msi/x resources in the first
> load because of the previous failure in phy_id check.

Is that all one sentence?  Can I buy a comma or semi-colon, Pat?  :)

More seriously, this description is not very helpful.  A good 
description precisely outlines the _solution_ ("fix msi/x resource 
leak"), perhaps with a bit of concise problem description ("failure to 
free msi/x resources").

Your description focuses mostly on what the user/tester experiences and 
observes, whereas in a changeset description the most important thing to 
communicate is to describe the engineering change to the driver (proper 
release of resources).

	Jeff

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html