netdev - Re: ssb: Fix DMA-API compilation for non-PCI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 03:56:35 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Michael Buesch <mb@...sch.de>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems

On Tue, Nov 11, 2008 at 12:32:00AM +0100, Michael Buesch wrote:
> On Monday 10 November 2008 23:53:43 David Miller wrote:
> > Then those architectures need to fix their implementations,
> > simply.  They aren't implementing the generic DMA interfaces
> > properly.  Other subsystems do make use of the generic DMA
> > interfaces in this way.
> > 
> > Even something as simple as checking for &pci_bus_type in the
> > dma_*() routines (like powerpc did for quite some time) is
> > enough to fix the problem.
> 
> Yeah, sure. The architectures are broken.
> But the bugreports hit _my_ code. I got pretty tired of forwarding stuff
> to the arch maintainers, so I implemented something that does work in
> every situation. The bugreports stopped immediately (Except this tiny build
> failure that does only hit under rare circumstances).
> 
> DMA is pretty much a mess, if you look at how ever arch does implement the API
> in a slightly different way.

We have tons of PCI drivers using the dma_ routines.  So please report
the broken architecture to get it fixes instead of whining.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html