[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2008 13:10:34 +0100
From: "Johann Baudy" <johaahn@...il.com>
To: "Lovich, Vitali" <vlovich@...lcomm.com>
Cc: "Evgeniy Polyakov" <zbr@...emap.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING
Hi Vitali,
> Found another issue. I'm not sure how your code managed to work, but in my patch I had to have skb_reset_network_header(skb) after a skb_reserve - otherwise, it would be rejected when I passed it on to the device.
That's not an issue with my device.
It is called in original packet_sendmsg(). I've missed it :)
>
> Also, there's no need to support both header versions in the tx path - since v2 should be used anyways and there's no legacy (v1 headers are deprecated no?), we can use v2 only in the tx path.
I think we have either to use our own TX header (we are using only
status field of V2) or to keep compatibility with all RX/TX headers
available.
Be compatible with V1/V2 makes TX code more flexible if there is a V3
in the future.
> Additionally, if the packet size is too long, the kernel has a responsibility to clear that flag (otherwise that slot will never free up).
I'm not sure to understand, could you please clarify ?
Thanks,
Johann
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists