netdev - Re: [PATCH] bnx2: fix poll_controller method so that proper structures are passed and all rx queues are checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C27F8246C663564A84BB7AB343977242151F4B18B9@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Tue, 11 Nov 2008 07:12:13 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'Neil Horman'" <nhorman@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jgarzik@...ox.com" <jgarzik@...ox.com>,
	"'davem@...emloft.net'" <davem@...emloft.net>
Subject: Re: [PATCH] bnx2: fix poll_controller method so that proper
 structures are passed and all rx queues are checked

Neil Horman wrote:

> Hey-
>       I noted recently that bnx2 had a few problems with its
> poll_controller
> method:
>
> 1) It passes a net_device structure to bnx2_interrupt, but
> bnx2_interrupt
> expects a bnx2_napi structure.
>
> 2) bnx2_interrupt never checks all its rx queues, so theres
> no guarantee that
> we'll see incomming frames.
>
> This patch should fix both those problems
>
> Regards
> Neil
>
> Signed-off-by: Neil Horman <nhorman@...driver.com>
>
>
>  bnx2.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
>
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index 430d430..9e1f0e3 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -7203,10 +7203,12 @@ bnx2_change_mtu(struct net_device
> *dev, int new_mtu)
>  static void
>  poll_bnx2(struct net_device *dev)
>  {
> +     int i;
>       struct bnx2 *bp = netdev_priv(dev);
>
>       disable_irq(bp->pdev->irq);
> -     bnx2_interrupt(bp->pdev->irq, dev);
> +     for (i = 0; i < bp->irq_nvecs; i++)
> +             bnx2_interrupt(bp->pdev->irq, &bp->bnx2_napi[i]);

Neil, thanks for the patch.

We should probably pass bp->irq_tbl[i].vector as 1st parameter
for correctness, even though it doesn't really matter in this
case since it is not used by bnx2_interrupt().

>       enable_irq(bp->pdev->irq);
>  }
>  #endif

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html