[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2008 17:18:06 +0100
From: Andi Kleen <ak@...ux.intel.com>
To: Patrick Ohly <patrick.ohly@...el.com>
CC: netdev@...r.kernel.org, Octavian Purdila <opurdila@...acom.com>,
Stephen Hemminger <shemminger@...tta.com>,
Ingo Oeser <netdev@...eo.de>,
John Ronciak <john.ronciak@...el.com>,
Eric Dumazet <dada1@...mosbay.com>,
Oliver Hartkopp <oliver@...tkopp.net>
Subject: Re: [RFC PATCH 11/13] time sync: generic infrastructure to map between
time stamps generated by a clock source and system time
> +
> +int clocksync_offset(struct clocksync *sync,
> + s64 *offset,
> + u64 *hwtstamp)
> +{
> + u64 starthw = 0, endhw = 0;
> + struct {
> + s64 offset;
> + s64 duration_sys;
> + } samples[100],
That should be separately allocated to avoid potential stack overflow.
Also as a style nit there are normally no {} around single line
statements.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists