netdev - Re: [PATCH 2.6.27] tcp_htcp: last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081112.014403.210407962.davem@davemloft.net>
Date:	Wed, 12 Nov 2008 01:44:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Doug.Leith@...m.ie
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH 2.6.27] tcp_htcp: last_cong bug fix

From: Douglas Leith <Doug.Leith@...m.ie>
Date: Wed, 12 Nov 2008 08:58:18 +0000

> This patch fixes a minor bug in tcp_htcp.c which has been
> highlighted by Lachlan Andrew and Lawrence Stewart.  Currently, the
> time since the last congestion event, which is stored in variable
> last_cong, is reset whenever there is a state change into
> TCP_CA_Open.  This includes transitions of the type
> TCP_CA_Open->TCP_CA_Disorder->TCP_CA_Open which are not associated
> with backoff of cwnd.  The patch changes last_cong to be updated
> only on transitions into TCP_CA_Open that occur after experiencing
> the congestion-related states TCP_CA_Loss, TCP_CA_Recovery,
> TCP_CA_CWR.
> 
> Signed-off-by:  Doug Leith <doug.leith@...m.ie>

Applied, but I still had to fix up a bunch of details :-(

+		ca->undo_last_cong = 0;  

That line had trailing whitespace.

+	case TCP_CA_Open: 

That one too.

+        		if (ca->undo_last_cong) { 

That line had an initial set of space characters, instead
of pure leading tab characters.

+				ca->last_cong = jiffies;   

More trailing whitespace.

+		break;	

And some more trailing whitespace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html