netdev - Re: atl1: use magic packet wake-on-lan only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <491B143C.5050404@redhat.com>
Date:	Wed, 12 Nov 2008 12:37:00 -0500
From:	Chris Snook <csnook@...hat.com>
To:	"J. K. Cliburn" <jcliburn@...il.com>
CC:	jeff@...zik.org, Jie.yang@...eros.com, netdev@...r.kernel.org
Subject: Re: atl1: use magic packet wake-on-lan only

J. K. Cliburn wrote:
> On Mon, 10 Nov 2008 13:42:25 -0500
> Chris Snook <csnook@...hat.com> wrote:
> 
>> J. K. Cliburn wrote:
>>> atl1: use magic packet wake-on-lan only
>>>
>>> Of the various WOL options provided in include/linux/ethtool.h, the
>>> L1 NIC supports only magic packet.  Remove all options except magic
>>> packet from the atl1 driver.
>> Technically, we could implement the rest via the programmable 
>> pattern-matching hardware, but that would be an immense amount of
>> work.
> 
> Thanks for the pointer to the pattern matching capability.  I had
> forgotten about it.
> 
> What prompted the patch was a user asking some questions off-list about
> the L1 and WOL, and I realized the atl1 driver was advertising WOL
> options that weren't implemented.
> 
> I think the magic-packet-only patch I submitted to Jeff is still
> relevant, but I'm going to explore the pattern matching capability and
> see if we can implement some additional WOL options.  IMHO, though,
> those should be provided in a separate (future) patch.  Do you agree?
> 
> Jay

Completely.  Programming the pattern matching hardware is a lot more 
involved than setting a single bit in the hardware.

Are there any other NICs that have pattern-matching WoLAN capability? 
If so, how do their drivers take advantage of them?  If it turns out to 
be a widely underutilized feature, it might make sense to let ethtool do 
the dirty work.

-- Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html