netdev - Re: [PATCH] isdn: use %pI4, remove get_{u8/u16/u32} and put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081113.224207.25857066.davem@davemloft.net>
Date:	Thu, 13 Nov 2008 22:42:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	netdev@...r.kernel.org, kkeil@...e.de
Subject: Re: [PATCH] isdn: use %pI4, remove get_{u8/u16/u32} and
 put_{u8/u16/u32} inlines

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Thu, 13 Nov 2008 21:17:25 -0800

> They would have been better named as get_be16, put_be16, etc.
> as they were hiding an endian shift inside.
> 
> They don't add much over explicitly coding the byteshifting
> and gcc sometimes has a problem with builtin_constant_p inside
> inline functions, so it may do a better job of byteswapping
> at compile time rather than runtime.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Applied, thanks Harvey.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html