lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Nov 2008 12:25:40 +0200 (EET) From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi> To: "Rémi Denis-Courmont" <remi.denis-courmont@...ia.com> cc: Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net 1/1] Phonet: refuse to send bigger than MTU packets On Fri, 14 Nov 2008, Rémi Denis-Courmont wrote: > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com> > --- > net/phonet/af_phonet.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/phonet/af_phonet.c b/net/phonet/af_phonet.c > index defeb7a..7ab30f6 100644 > --- a/net/phonet/af_phonet.c > +++ b/net/phonet/af_phonet.c > @@ -144,8 +144,8 @@ static int pn_send(struct sk_buff *skb, struct net_device *dev, > struct phonethdr *ph; > int err; > > - if (skb->len + 2 > 0xffff) { > - /* Phonet length field would overflow */ > + if (skb->len + 2 > 0xffff /* Phonet length field limit */ || It would by much better to have a well named constant there rather than such crazy and messy contruct with a comment. -- i.
Powered by blists - more mailing lists