netdev - Re: [stable] [BUG] net: fix /proc/net/snmp as memory corruptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491E8A47.1090007@cosmosbay.com>
Date:	Sat, 15 Nov 2008 09:37:27 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Greg KH <greg@...ah.com>
CC:	stable@...nel.org, "David S. Miller" <davem@...emloft.net>,
	netdev@...r.kernel.org
Subject: Re: [stable] [BUG] net: fix /proc/net/snmp as memory corruptor

Greg KH a écrit :
> On Sat, Nov 15, 2008 at 06:25:33AM +0100, Eric Dumazet wrote:
>> Greg KH a écrit :
>>> On Fri, Nov 14, 2008 at 06:08:48AM +0100, Eric Dumazet wrote:
>>>> Hello Greg
>>>>
>>>> A patch was submited about /proc/net/snmp being a memory corruptor and 
>>>> not SMP safe
>>>>
>>>> (commit b971e7ac834e9f4bda96d5a96ae9abccd01c1dd8)
>>>>
>>>> These bugs are present on 2.6.26 & 2.6.27.
>>> I looking at this, it doesn't seem to apply at all to the .27 tree.  If
>>> David doesn't object, care to backport it there and send it to
>>> stable@...nel.org?
>> Strange... I just tried to apply patch on top of a fresh linux-2.6.27.6 
>> tree and got no error
>>
>> # patch -p1 < /tmp/icmp_snmp.patch
>> patching file net/ipv4/proc.c
>> #
> 
> I've attached the patch I tried to apply below.  It fails with:
> 	$ patch -p1 --dry-run < ../net-fix-proc-net-snmp-as-memory-corruptor.patch 
> 	patching file net/ipv4/proc.c
> 	Hunk #1 FAILED at 237.
> 	1 out of 1 hunk FAILED -- saving rejects to file net/ipv4/proc.c.rej
> 
> 
> Any thoughts?
> 
> thanks,
> 
> greg k-h
> 

Yes, you lost all the '\' character in "\n" sequences... 
Also one missing ":" at the end of one line

I dont know how you did it :)

Here is the (manually) corrected file 

View attachment "p.patch" of type "text/plain" (2575 bytes)