[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081117.114952.81357471.davem@davemloft.net>
Date: Mon, 17 Nov 2008 11:49:52 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: csnook@...hat.com
Cc: jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
netdev@...r.kernel.org
Subject: Re: [v2,PCI] move ICHx GbE NVM write-protection from e1000e to PCI
quirk
From: Chris Snook <csnook@...hat.com>
Date: Mon, 17 Nov 2008 14:40:32 -0500
> David Miller wrote:
> > I'm less than thrilled with this patch so I'm not going to apply it.
> > I mean, what are we going to do, for every single device that has a
> > NVRAM we're going to add some PCI quirk and some new global foo_*
> > kernel command line option to turn it off?
> > That doesn't make any sense at all, sorry.
>
> Could we protect it in a PCI quirk, and optionally unprotect it in the driver?
I think it's an overreaction, frankly.
Doing it purely in the driver should be fine.
Again are we going to add a NVRAM protect quirk for every PCI
device on the planet that has a NVRAM?
It's not appropriate at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists