netdev - Re: [PATCH] isdn: bugfix in isdn_net_ciscohdlck_slarp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Nov 2008 19:54:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	viro@...IV.linux.org.uk, kkeil@...e.de, netdev@...r.kernel.org
Subject: Re: [PATCH] isdn: bugfix in isdn_net_ciscohdlck_slarp_send_reply,
 trivial sparse fixes

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Fri, 14 Nov 2008 09:33:49 -0800

> commit a144ea4b7a13087081ab5402fa9ad0bcfd249e67 [IPV4]: annotate struct in_ifaddr
> 
> Missed the extra byteswap because the previous isdn inline helpers
> hid the extra htonl inside put_u32.  This was causing an extra byteswap
> on little-endian arches.
> 
> While here, do the trivial annotation of the struct ip_ports and change
> the remaining casts to __be16 where applicable.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
> Dave, the yesterday's patch was a zero-change patch that exposed this
> bug, this patch changes behavior in the above-referenced function.

Well, you've created an incredibly difficult situation for me.

The bug exists in 2.6.28-rcX but your cleanup patch was only appropriate
for net-next-2.6 so that's where it went.

But this bug fix here will only apply on top of that cleanup.

This is wrong, please propose a way to correct this so that 2.6.28-rcX can
get this bug fixed properly, without a dependency on a cleanup with is
not appropriate for 2.6.28-rcX.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html