netdev - Re: [PATCH] net: Cleanup of af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4921133D.6070800@cosmosbay.com>
Date:	Mon, 17 Nov 2008 07:46:21 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Cleanup of af_unix

David Miller a écrit :
> From: Eric Dumazet <dada1@...mosbay.com>
> Date: Mon, 17 Nov 2008 07:10:47 +0100
> 
>> @@ -1998,7 +1990,8 @@ static unsigned int unix_poll(struct file * file, struct socket *sock, poll_tabl
>>  		mask |= POLLIN | POLLRDNORM;
>>  
>>  	/* Connection-based need to check for termination and startup */
>> -	if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) && sk->sk_state == TCP_CLOSE)
>> +	if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) &&
>> +		sk->sk_state == TCP_CLOSE)
>>  		mask |= POLLHUP;
>>  
>>  	/*
> 
> This should instead be:
> 
> 	if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) &&
> 	    sk->sk_state == TCP_CLOSE)

Oops thats right.

> 
>> Some long lines (over 80 columns) were not changed, please tell me if you prefer
>> them go.
> 
> I'm ambivalent, at which point it's just noise and merge hassles, so let's
> just leave it alone.

OK, let's try with the updated version then :)

Thanks

[PATCH] net: Cleanup of af_unix

This is a pure cleanup of net/unix/af_unix.c to meet current code style standards

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
--- 
 net/unix/af_unix.c |  117 ++++++++++++++++++++-----------------------
 1 files changed, 55 insertions(+), 62 deletions(-)

View attachment "af_unix_cleanup.patch" of type "text/plain" (11785 bytes)