netdev - Re: [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4921161B.90605@cn.fujitsu.com>
Date:	Mon, 17 Nov 2008 14:58:35 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev_priv

David Miller said the following on 2008-11-17 14:36:
> From: Wang Chen <wangchen@...fujitsu.com>
> Date: Mon, 17 Nov 2008 14:04:13 +0800
> 
>> -#ifdef __mc68000__
>> -	cache_push(virt_to_phys((void *)(dev->mem_start)), 4096);
>> -	cache_clear(virt_to_phys((void *)(dev->mem_start)), 4096);
>> -	kernel_set_cachemode((void *)(dev->mem_start), 4096, IOMAP_NOCACHE_SER);
>> -#endif
> 
> Do you have any idea what this code is doing that you are removing?
> 
> It's changing the cache mode of the memory behind ->mem_start because
> this "lp" struct is directly accessed by the hardware, and without
> these operations the CPU and the device won't see consistent
> values in the structure.
> 
> Therefore your change breaks the driver.
> 

Yes. I was wrong.
Will send a patch again.
Thank you for stopping my fool code.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html