netdev - Re: [PATCH 1/3] virtio_net: Recycle some more rx buffer pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081116.230827.88286434.davem@davemloft.net>
Date:	Sun, 16 Nov 2008 23:08:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rusty@...tcorp.com.au
Cc:	netdev@...r.kernel.org, markmc@...hat.com
Subject: Re: [PATCH 1/3] virtio_net: Recycle some more rx buffer pages

From: Rusty Russell <rusty@...tcorp.com.au>
Date: Mon, 17 Nov 2008 17:35:43 +1030

> On Monday 17 November 2008 14:15:05 David Miller wrote:
> > From: Rusty Russell <rusty@...tcorp.com.au>
> > Date: Mon, 17 Nov 2008 13:44:57 +1030
> >
> > > @@ -82,6 +82,16 @@ static void give_a_page(struct virtnet_info *vi,
> > > struct page *page)
> >
> > -E_EMAIL_CLIENT_NEWLINES
> 
> Each time we re-fill the recv queue with buffers, we allocate
> one too many skbs and free it again when adding fails. We should
> recycle the pages allocated in this case.
> 
> A previous version of this patch made trim_pages() trim trailing
> unused pages from skbs with some paged data, but this actually
> caused a barely measurable slowdown.
> 
> Signed-off-by: Mark McLoughlin <markmc@...hat.com>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au> (use netdev_priv)

-ETOOLATE, and...

> -			give_a_page(dev->priv, skb_shinfo(skb)->frags[i].page);

this wouldn't have applied to net-next-2.6, the dev->priv reads
netdev_priv(dev) there.

Anyways, as I said in my other reply I fixed all of this up because
I was tired of waiting... :)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html