netdev - Re: [PATCH,RESEND] phylib: fix premature freeing of struct mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081118205211.GA15366@xi.wantstofly.org>
Date:	Tue, 18 Nov 2008 21:52:11 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	jeff@...zik.org
Cc:	Bryan Wu <cooloney@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH,RESEND] phylib: fix premature freeing of struct mii_bus

On Tue, Nov 18, 2008 at 03:33:07PM +0100, Lennert Buytenhek wrote:

> Commit 46abc02175b3c246dd5141d878f565a8725060c9 ("phylib: give mdio
> buses a device tree presence") added a call to device_unregister() in
> a situation where the caller did not intend for the device to be
> freed yet, but apart from just unregistering the device from the
> system, device_unregister() does an additional put_device() that is
> intended to free it.
> 
> The right function to use in this situation is device_del(), which
> unregisters the device from the system like device_unregister() does,
> but without dropping the reference count an additional time.
>     
> Bug report from Bryan Wu <cooloney@...nel.org>.

Sorry, ignore this, it seems that you already merged this on friday.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html