[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081118125840.e3c7745d.akpm@linux-foundation.org>
Date: Tue, 18 Nov 2008 12:58:40 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Dan Williams <dan.j.williams@...el.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
maciej.sosnowski@...el.com, hskinnemoen@...el.com,
g.liakhovetski@....de, nicolas.ferre@...el.com
Subject: Re: [PATCH 08/13] dmatest: convert to dma_request_channel
On Tue, 18 Nov 2008 11:24:21 -0700
Dan Williams <dan.j.williams@...el.com> wrote:
> Ok, so I now have:
> # git shortlog `stg id akpm-review-spell-fixes.patch`^..
> Dan Williams (6):
> dmaengine review: spelling/grammar fixes
> dmaengine review: dma_wait_for_async_tx clarification
> dmaengine review: fix up kernel doc for dma_list_mutex usage
> dmaengine review: propagate alloc_chan_resources error code
> dmaengine review: return meaningful error code from initcall
> dmaengine review: dmatest stop on dmatest_add_channel failure
>
> May I add your Reviewed-by for these and the original 13.
Sure. Ignorantly-stared-at-by: would be more appropriate though.
> I could fold
> these into the originals but perhaps it is better to document fixups
> when they are the result of review [1].
I think that a clean commit trail is more important. One can always
retain documentation/attributions/etc in the changelog when folding.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists