netdev - Re: macb phy address bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492281C9.6060006@st.com>
Date:	Tue, 18 Nov 2008 09:50:17 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	David Miller <davem@...emloft.net>
Cc:	giulio.benetti@...ronovasrl.com, netdev@...r.kernel.org
Subject: Re: macb phy address bug?

In my opinion, we need to rework this patch again for two reasons:
1) it doesn't cover the case when the PHYID is 0xffffffff.
2) we need to add an explicit comment on the PHYID check to highlight that
    this is a  work-around the broken hardware (in case we get 0xffff or 
0x0).
I've also tested it on several PHY devices: e.g. smsc lan 8700, ste101p, 
ste100p,
DP83865 National GPHY.
Where, for some of these, we need to treat the phyid=0 as wrong UID.
Please, review the attached patch.

Regards,
Peppe

David Miller wrote:
> I've applied this patch to net-2.6, thanks.
>
> As mentioned there is some rare chance that the new
> zero test could cause problems, in which case we'll
> need to undo that part.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   


View attachment "phy_dev_uid_detection.patch" of type "text/x-patch" (820 bytes)