netdev - Re: [PATCH 4/6] mv643xx_eth: implement ->set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081120.035931.187406968.davem@davemloft.net>
Date:	Thu, 20 Nov 2008 03:59:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] mv643xx_eth: implement ->set_rx_mode()

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Tue, 18 Nov 2008 23:29:56 +0100

> Currently, if multiple unicast addresses are programmed into a
> mv643xx_eth interface, the core networking will resort to enabling
> promiscuous mode on the interface, as mv643xx_eth does not implement
> ->set_rx_mode().
> 
> This patch switches mv643xx_eth over from ->set_multicast_list()
> to ->set_rx_mode(), and implements support for secondary unicast
> addresses.  The hardware can handle multiple unicast addresses as
> long as their first 11 nibbles are the same (i.e. are of the form
> xx:xx:xx:xx:xx:xy where the x part is the same for all addresses), so
> if that is the case, we use that mode.  If it's not the case, we enable
> unicast promiscuous mode in the hardware, which is slightly better than
> enabling promiscuous mode for multicasts as well, which is what would
> happen before.
> 
> While we are at it, change the programming sequence so that we
> don't clear all filter bits first, so we don't lose all incoming
> packets while the filter is being reprogrammed.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html