netdev - Re: SKB truesize bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081120.040311.01043059.davem@davemloft.net>
Date:	Thu, 20 Nov 2008 04:03:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bkostya@...mail.com
Cc:	netdev@...r.kernel.org
Subject: Re: SKB truesize bug

From: Kostya B <bkostya@...mail.com>
Date: Thu, 20 Nov 2008 11:59:28 +0000

> Perhaps we should take a closer look on pskb_expand_head()
> 
> And add 
> 
> +skb->truesize = size + sizeof(struct sk_buff);

You can't.  If a socket is attached to the skb it's buffer
accounting will get corrupted if you modify skb->truesize.

This has been explained a thousand times on this list.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html