netdev - Re: [PATCH 02/33] netdev: introduce dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081120.042723.155391181.davem@davemloft.net>
Date:	Thu, 20 Nov 2008 04:27:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 02/33] netdev: introduce dev_get_stats()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Thu, 20 Nov 2008 10:17:02 +0100

> I have one comment about netdev stats
> 
> on 32bit arches, SMP :
> 
> struct net_device = 0x480
> offsetof(struct net_device, features)=0x44
> offsetof(struct net_device, stats)=0x50
> offsetof(struct net_device, stats.rx_packets)=0x50
> 
> So we trash features field, thats a problem...
> 
> I wonder if we could zap stats from netdev structure.
> Some drivers already use external stats handling (like loopback)

Some... but most just want a single stats structure, and that's
what this is for.

Let's just put the appropriate alignment tags in struct net_device
after all of this dust settles, ok?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html