netdev - Re: [PATCH 2/2] phylib: make mdio-gpio work without OF (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200811201724.18731.laurentp@cse-semaphore.com>
Date:	Thu, 20 Nov 2008 17:24:18 +0100
From:	Laurent Pinchart <laurentp@...-semaphore.com>
To:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-embedded@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH 2/2] phylib: make mdio-gpio work without OF (v4)

On Friday 14 November 2008 11:24:34 Paulius Zaleckas wrote:
> make mdio-gpio work with non OpenFirmware gpio implementation.
>
> Aditional changes to mdio-gpio:
> - use gpio_request() and gpio_free()
> - place irq[] array in struct mdio_gpio_info
> - add module description, author and license
> - add note about compiling this driver as module
> - rename mdc and mdio function (were ugly names)
> - change MII to MDIO in bus name
> - add __init __exit to module (un)loading functions
> - probe fails if no phys added to the bus
> - kzalloc bitbang with sizeof(*bitbang)
>
> Changes since v3:
> - keep bus naming "%x" to be compatible with existing drivers.
>
> Changes since v2:
> - more #ifdefs reduction
> - platform driver will be registered on OF platforms also
> - unified platform and OF bus_id to phy%i
>
> Changes since v1:
> - removed NO_IRQ
> - reduced #idefs
>
> Laurent, please test this driver under OF.

No obvious issue found.

Acked-by: Laurent Pinchart <laurent.pinchart@...net.be>

> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
> Cc: Laurent Pinchart <laurent.pinchart@...net.be>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Mike Frysinger <vapier.adi@...il.com>

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html