netdev - Re: [PATCH 01/33] netdev: network device operations infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081119.212650.102527885.davem@davemloft.net>
Date:	Wed, 19 Nov 2008 21:26:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 01/33] netdev: network device operations infrastructure

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 17 Nov 2008 15:42:08 -0800

> This patch changes the network device internal API to move adminstrative
> operations out of the network device structure and into a separate structure.
> 
> This patch involves some hackery to maintain compatablity between the
> new and old model, so all 300+ drivers don't have to be changed at once.
> For drivers that aren't converted yet, the netdevice_ops virt function list
> still resides in the net_device structure. For old protocols, the new
> net_device_ops are copied out to the old net_device pointers.
> 
> After the transistion is completed the nag message can be changed to
> an WARN_ON, and the compatiablity code can be made configurable.
> 
> Some function pointers aren't moved:
> * destructor can't be in net_device_ops because 
>   it may need to be referenced after the module is unloaded.
> * neighbor setup is manipulated in a couple of places that need special
>   consideration
> * hard_start_xmit is in the fast path for transmit.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Ok, I'm applying this but it needs the following interdiff to cure some
build failures.

And I'm also going to add the "ndo_*" prefix to the netdev_ops member
names as suggested by Eric.

I'll fix up the remaining patches as needed, so don't worry about that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html