netdev - Re: [PATCH] smsc95xx: add tx checksum offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF79130DF4.191FC25A-ON80257507.002E9C9F-80257507.00309F9A@smsc.com>
Date:	Thu, 20 Nov 2008 08:50:16 +0000
From:	Steve.Glendinning@...c.com
To:	David Miller <davem@...emloft.net>
Cc:	ian.saturley@...c.com, netdev@...r.kernel.org
Subject: Re: [PATCH] smsc95xx: add tx checksum offload support

Hi David,

David Miller <davem@...emloft.net> wrote on 19/11/2008 22:28:55:

> From: Steve Glendinning <steve.glendinning@...c.com>
> Date: Mon, 17 Nov 2008 10:50:00 +0000
> 
> > @@ -757,6 +787,7 @@ static int smsc95xx_phy_initialize(struct usbnet 
*dev)
> >  static int smsc95xx_reset(struct usbnet *dev)
> >  {
> >     struct smsc95xx_priv *pdata = (struct smsc95xx_priv 
*)(dev->data[0]);
> > +   struct net_device *netdev = dev->net;
> >     u32 read_buf, write_buf, burst_cap;
> >     int ret = 0, timeout;
> >     DECLARE_MAC_BUF(mac);
> 
> This smsc95xx_reset function doesn't even exist in the current driver.

Are you sure you're looking at the same drivers/net/usb/smsc95xx.c?  In 
both Linus's tree and net-next-2.6 this function is on line 757.

The patch was against Linus's tree, the version in net-next-2.6 also has 
Johannes Berg's print_mac patch applied so this section of code no longer 
has DECLARE_MAC_BUF(mac);.  Would you like me to rebase against 
net-next-2.6 and resubmit?

Regards,
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@...c.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html