netdev - Re: [PATCH 30/33] tg3: convert to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081119.172116.09278780.davem@davemloft.net>
Date:	Wed, 19 Nov 2008 17:21:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	mcarlson@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 30/33] tg3: convert to net_device_ops

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 19 Nov 2008 13:07:27 -0800

> On Wed, 19 Nov 2008 13:04:47 -0800
> "Matt Carlson" <mcarlson@...adcom.com> wrote:
> 
> > On Mon, Nov 17, 2008 at 05:37:06PM -0800, Stephen Hemminger wrote:
> > > Convert this driver to network device ops.
> > > 
> > > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> > > 
> > > ---
> > > Handle non-vlan build.
> > > 
> > > --- a/drivers/net/tg3.c	2008-11-17 17:21:58.000000000 -0800
> > > +++ b/drivers/net/tg3.c	2008-11-17 17:26:45.000000000 -0800
> > > @@ -13343,6 +13343,24 @@ static void __devinit tg3_init_coal(stru
> > >  	}
> > >  }
> > >  
> > > +static const struct net_device_ops tg3_netdev_ops = {
> > > +	.open			= tg3_open,
> > > +	.stop			= tg3_close,
> > 
> > One more completely trivial nit.  Is there a reason why you chose
> > the verbs to be "open" and "stop" rather than "open" and "close" or
> > "start" and "stop"?
> 
> Because that is what they were before (but in a different place).

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html