netdev - Re: [NET-NEXT PATCH 08/14] e1000e: link up/down messages must follow a specific format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227294295.23438.17.camel@localhost.localdomain>
Date:	Fri, 21 Nov 2008 14:04:55 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org,
	Bruce Allan <bruce.w.allan@...el.com>
Subject: Re: [NET-NEXT PATCH 08/14] e1000e: link up/down messages must
	follow a specific format

On Fri, 2008-11-21 at 11:01 -0800, Jeff Kirsher wrote:
> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> The system log messages created on a link status change need to follow a
> specific format to work with tools some customers use.

Um, shouldn't those tools be listening to netlink for carrier events, or
are these tools run on a separate machine using on some later date using
the logs from the machine with the e1000e?

Dan

> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> 
>  drivers/net/e1000e/netdev.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 7eb1a36..cd6d132 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3408,7 +3408,10 @@ static void e1000_print_link_info(struct e1000_adapter *adapter)
>  	struct e1000_hw *hw = &adapter->hw;
>  	u32 ctrl = er32(CTRL);
>  
> -	e_info("Link is Up %d Mbps %s, Flow Control: %s\n",
> +	/* Link status message must follow this format for user tools */
> +	printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s, "
> +	       "Flow Control: %s\n",
> +	       adapter->netdev->name,
>  	       adapter->link_speed,
>  	       (adapter->link_duplex == FULL_DUPLEX) ?
>  	                        "Full Duplex" : "Half Duplex",
> @@ -3618,7 +3621,9 @@ static void e1000_watchdog_task(struct work_struct *work)
>  		if (netif_carrier_ok(netdev)) {
>  			adapter->link_speed = 0;
>  			adapter->link_duplex = 0;
> -			e_info("Link is Down\n");
> +			/* Link status message must follow this format */
> +			printk(KERN_INFO "e1000e: %s NIC Link is Down\n",
> +			       adapter->netdev->name);
>  			netif_carrier_off(netdev);
>  			netif_tx_stop_all_queues(netdev);
>  			if (!test_bit(__E1000_DOWN, &adapter->state))
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html