netdev - Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2008 21:20:45 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	cooldavid@...ldavid.org, David Miller <davem@...emloft.net>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	Ethan <ethanhsiao@...cron.com>, akeemting <akeem@...cron.com>
Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

Going through this driver for net_device_ops makes me wonder
why some other things wer not caught during the review process.

1. Obfuscation by macro which looks like some "vendor support older kernels"
   stuff.  See the wrapping of NAPI and NET_STAT

2. 5 tasklets for thing that could be done by NAPI and one tasklet

3. 4 atomic variables for things that should be already covered by locks

4. 3 locks, seems like more than needed.

5. PCI setup of max read request size should be done via pci_set_readrq
   not by direct manipulation of PCI registers.

6. Not using pci dma allocation which is more standard convention

7. NAPI weight is very large 256 (vs normal 64)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html