netdev - Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081121161455.M43757@cooldavid.org>
Date:	Sat, 22 Nov 2008 00:18:07 +0800
From:	"Guo-Fu Tseng" <cooldavid@...ldavid.org>
To:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>
Cc:	akeem@...cron.com, ethanhsiao@...cron.com, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

On Thu, 20 Nov 2008 22:45:42 -0800, Stephen Hemminger wrote
> On Thu, 20 Nov 2008 21:36:27 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
> > From: Stephen Hemminger <shemminger@...tta.com>
> > Date: Thu, 20 Nov 2008 21:20:45 -0800
> > 
> > > 6. Not using pci dma allocation which is more standard convention
> > 
> > Using the generic DMA interfaces is actually preferred.  There is
> > no effective difference other than using a more generic interface.
> 
> Ok, but this???
> 
> #define NET_STAT(priv) (priv->dev->stats)
> #define NETDEV_GET_STATS(netdev, fun_ptr)
> #define DECLARE_NET_DEVICE_STATS
> 
> #define DECLARE_NAPI_STRUCT struct napi_struct napi;
> #define NETIF_NAPI_SET(dev, napis, pollfn, q) \
> 	netif_napi_add(dev, napis, pollfn, q);
> #define JME_NAPI_HOLDER(holder) struct napi_struct *holder
> #define JME_NAPI_WEIGHT(w) int w
> #define JME_NAPI_WEIGHT_VAL(w) w
> #define JME_NAPI_WEIGHT_SET(w, r)
> #define JME_RX_COMPLETE(dev, napis) netif_rx_complete(dev, napis)
> #define JME_NAPI_ENABLE(priv) napi_enable(&priv->napi);
> #define JME_NAPI_DISABLE(priv) \
> 	if (!napi_disable_pending(&priv->napi)) \
> 		napi_disable(&priv->napi);
> #define JME_RX_SCHEDULE_PREP(priv) \
> 	netif_rx_schedule_prep(priv->dev, &priv->napi)
> #define JME_RX_SCHEDULE(priv) \
> 	__netif_rx_schedule(priv->dev, &priv->napi);
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

You are right about it.
I have another jme.h which can compile for older kernel.
It can be removed if it should be.

Guo-Fu Tseng

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html