netdev - Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2008 16:57:12 -0800
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	rdreier@...co.com, kaber@...sh.net, netdev@...r.kernel.org,
	jeff@...zik.org, alexander.h.duyck@...el.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

On Fri, Nov 21, 2008 at 4:48 PM, David Miller <davem@...emloft.net> wrote:
> From: Roland Dreier <rdreier@...co.com>
> Date: Fri, 21 Nov 2008 09:58:37 -0800
>
>>  > > +
>>  > > +config DCBNL
>>  > > +        bool "Data Center Bridging netlink interface support"
>>  > > +        depends on DCB
>>  > > +        default n
>>  > > +        ---help---
>>  > > +          This option turns on the netlink interface
>>  > > +          (dcbnl) for Data Center Bridging capable devices.
>>  > > +
>>  > > +          If unsure, say N.
>>
>> Now that I look at this config, it looks rather strange.  When does is
>> ever make sense to enable DCB but not DCBNL?  How else does one
>> configure all the DCB parameters except by running dcbd in userspace?
>> Should there even be a separate DCBNL option at all?
>
> Yes, that makes sense.
>
> If DCBNL is the only way to enable and control DCB, there is no sense
> to have two seperate options.
> --
>

Sounds fine with me.  I will get a patch out later.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html