netdev - Re: [NET-NEXT PATCH 14/14] e1000e: check return code from NVM accesses and fix bank detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081121.170253.133376207.davem@davemloft.net>
Date:	Fri, 21 Nov 2008 17:02:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org, bruce.w.allan@...el.com
Subject: Re: [NET-NEXT PATCH 14/14] e1000e: check return code from NVM
 accesses and fix bank detection

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 21 Nov 2008 11:02:56 -0800

> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> Check return code for all NVM accesses[1] and error out accordingly; log
> a debug message for failed accesses.
> 
> For ICH8/9, the valid NVM bank detect function was not checking whether the
> SEC1VAL (sector 1 valid) bit in the EECD register was itself valid (bits 8
> and 9 also have to be set).  If invalid, it would have defaulted to the
> possibly invalid bank 0.  Instead, try to use the valid bank detection
> method used by ICH10 which has been cleaned up a bit.
> 
> [1] - reads and updates only; not writes because those are only writing to
> the Shadow RAM, the update following the write is the only thing actually
> writing the modified Shadow RAM contents to the NVM.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>

Applied.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html