netdev - Re: [PATCH] 8139too: use err.h macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123183645.GA11340@havoc.gtf.org>
Date:	Sun, 23 Nov 2008 13:36:45 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Francois Romieu <romieu@...zoreil.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] 8139too: use err.h macros

On Sun, Nov 23, 2008 at 10:22:37AM -0800, Stephen Hemminger wrote:
> Instead of using call by reference use the PTR_ERR macros to handle
> return value with error case. Compile tested only.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> --- a/drivers/net/8139too.c	2008-11-23 10:16:26.000000000 -0800
> +++ b/drivers/net/8139too.c	2008-11-23 10:19:05.000000000 -0800
> @@ -741,8 +741,7 @@ static void rtl8139_chip_reset (void __i
>  }
>  
>  
> -static int __devinit rtl8139_init_board (struct pci_dev *pdev,
> -					 struct net_device **dev_out)
> +static __devinit struct net_device * rtl8139_init_board (struct pci_dev *pdev)
>  {
>  	void __iomem *ioaddr;
>  	struct net_device *dev;

I won't NAK this, but I do wonder why a solution based on yucky
magic typecasting is preferred...?

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html