netdev - Re: [PATCH 02/10] tcp: move tcp_simple_retransmit to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081124190710.GA6703@one.firstfloor.org>
Date:	Mon, 24 Nov 2008 20:07:10 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 02/10] tcp: move tcp_simple_retransmit to tcp_input

On Mon, Nov 24, 2008 at 06:58:25PM +0200, Ilpo Järvinen wrote:
> On Mon, 24 Nov 2008, Andi Kleen wrote:
> 
> > "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi> writes:
> > 
> > tcp: move tcp_simple_retransmit to tcp_input
> > 
> > Why? It seems like a clear output function.
> 
> What makes you think so? It's as much output as e.g., tcp_enter_loss

the path mtu code calls it to output a packet.

> (or in fact less than that since enter_loss is triggered mainly by rto)?

enter_loss doesn't send a packet.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html