netdev - Re: [PATCH] eth: Declare an optimized compare_ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081123.224621.07006022.davem@davemloft.net>
Date:	Sun, 23 Nov 2008 22:46:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] eth: Declare an optimized compare_ether_addr_64bits()
 function

From: Eric Dumazet <dada1@...mosbay.com>
Date: Mon, 24 Nov 2008 07:27:46 +0100

> David Miller a écrit :
> > From: Eric Dumazet <dada1@...mosbay.com>
> > Date: Sat, 22 Nov 2008 08:19:17 +0100
> > 
> >> This patch implements a compare_ether_addr_64bits() function, that
> >> handles the case of x86 cpus, but might be used on other arches as
> >> well, if their potential misaligned long word reads are not
> >> expensive.
> > We have a test for this, HAVE_EFFICIENT_UNALIGNED_ACCESS
> > Please use that instead of CONFIG_X86 and I'll apply this
> > to net-next-2.6
> > 
> 
> Excellent !
> 
> I missed this cool feature.

Sorry, one last nit.

If the platform defines HAVE_EFFICIENT_UNALIGNED_ACCESS, there
is not point in going and using the get_unaligned() interfaces.
They are by definition a NOP in such cases.

So I toss them while applying this second version of your
patch, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html