netdev - Re: [PATCH] DCB: fix kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2008 17:17:11 -0800
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org
Subject: Re: [PATCH] DCB: fix kconfig option

On Mon, Nov 24, 2008 at 5:07 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> Jeff Kirsher wrote:
>> Since the netlink option for DCB is necessary to actually be useful,
>> simplified the Kconfig option.  In addition, added useful help text for the
>> Kconfig option.
>>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> ---
>>
>>  drivers/net/Kconfig            |    4 ++--
>>  drivers/net/ixgbe/Makefile     |    2 +-
>>  drivers/net/ixgbe/ixgbe.h      |    2 +-
>>  drivers/net/ixgbe/ixgbe_main.c |   10 +++++-----
>>  include/linux/netdevice.h      |    4 ++--
>>  net/Makefile                   |    4 ++--
>>  net/dcb/Kconfig                |   24 +++++++++++++++++-------
>>  net/dcb/dcbnl.c                |    2 +-
>>  8 files changed, 31 insertions(+), 21 deletions(-)
>
>> diff --git a/net/Makefile b/net/Makefile
>> index e5af3dc..4ccc0c7 100644
>> --- a/net/Makefile
>> +++ b/net/Makefile
>> @@ -56,8 +56,8 @@ obj-$(CONFIG_NETLABEL)              += netlabel/
>>  obj-$(CONFIG_IUCV)           += iucv/
>>  obj-$(CONFIG_RFKILL)         += rfkill/
>>  obj-$(CONFIG_NET_9P)         += 9p/
>> -ifeq ($(CONFIG_DCBNL),y)
>> -obj-$(CONFIG_DCB)            += dcb/
>> +ifeq ($(CONFIG_DCB),)
>
> ifeq {empty/nothing} ?  or ifeq y ?

Good catch, interesting that I did not catch that during compile testing.

>> +obj-y                                += dcb/
>>  endif
>>
>>  ifeq ($(CONFIG_NET),y)
>> diff --git a/net/dcb/Kconfig b/net/dcb/Kconfig
>> index bdf3880..a250498 100644
>> --- a/net/dcb/Kconfig
>> +++ b/net/dcb/Kconfig
>> @@ -1,12 +1,22 @@
>>  config DCB
>> -        tristate "Data Center Bridging support"
>> -
>> -config DCBNL
>> -     bool "Data Center Bridging netlink interface support"
>> -     depends on DCB
>> +        bool "Data Center Bridging support"
>
> Accidental conversion of tab to spaces.

Thanks, again.

>>       default n
>>       ---help---
>> -       This option turns on the netlink interface
>> -       (dcbnl) for Data Center Bridging capable devices.
>> +       This enables support for configuring Data Center Bridging (DCB)
>> +       features on DCB capable Ethernet adapters via rtnetlink.  Say 'Y'
>> +       if you have a DCB capable Ethernet adapter which supports this
>> +       interface and you are connected to a DCB capable switch.
>> +
>> +       DCB is a collection of Ethernet enhancements which allow DCB capable
>> +       NICs and switches to support network traffic with differing
>> +       requirements (highly reliable, no drops vs. best effort vs. low
>> +       latency) to co-exist on Ethernet.
>> +
>> +       DCB features include:
>> +         Enhanced Transmission Selection (aka Priority Grouping) - provides a
>> +           framework for assigning bandwidth guarantees to traffic classes.
>> +         Priority-based Flow Control (PFC) - a MAC control pause frame which
>> +           works at the granularity of the 802.1p priority instead of the
>> +           link (802.3x).
>>
>>         If unsure, say N.
>
>
> --
> ~Randy
> --

Fixed and sending an updated patch.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html