netdev - Re: [PATCH] pkt_sched: sch_api: Remove qdisc_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2008 12:44:21 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	David Miller <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: sch_api: Remove qdisc_list_lock

Jarek Poplawski wrote:
> After implementing qdisc->ops->peek() there is no more calling
> qdisc_tree_decrease_qlen() without rtnl_lock(), so qdisc_list_lock
> added by commit: f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b "pkt_sched:
> Fix qdisc list locking" can be removed.

I might be misunderstanding something, but qdisc_tree_decrease_qlen()
doesn't need rtnl_lock() but the sch_tree_lock() since it changes
q.qlen.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html