netdev - Re: sumgem problems with initializiation order at a 1000SX SERDES card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081126.011809.241693537.davem@davemloft.net>
Date:	Wed, 26 Nov 2008 01:18:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Hermann.Lauer@....uni-heidelberg.de
Cc:	netdev@...r.kernel.org
Subject: Re: sumgem problems with initializiation order at a 1000SX SERDES
 card

From: Hermann Lauer <Hermann.Lauer@....uni-heidelberg.de>
Date: Tue, 25 Nov 2008 11:30:29 +0100

> PS: There is only one "writeb" call in the code to reset the PCS, but the 
> value is read with a readl. Typo ?

That is definitely a bug, which I've fixed as follows.

I don't know about the rest of your report at this point, sorry.

sungem: Fix PCS_MIICTRL register write in gem_init_phy().

Use writel not writeb.

Noticed by Hermann Lauer.

Signed-off-by: David S. Miller <davem@...emloft.net>
---
 drivers/net/sungem.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 4291458..1349e41 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1714,7 +1714,7 @@ static void gem_init_phy(struct gem *gp)
 		/* Reset PCS unit. */
 		val = readl(gp->regs + PCS_MIICTRL);
 		val |= PCS_MIICTRL_RST;
-		writeb(val, gp->regs + PCS_MIICTRL);
+		writel(val, gp->regs + PCS_MIICTRL);
 
 		limit = 32;
 		while (readl(gp->regs + PCS_MIICTRL) & PCS_MIICTRL_RST) {
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html