netdev - Re: [PATCH] net: hp-plus uses eip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492CE6A4.5040404@oracle.com>
Date:	Tue, 25 Nov 2008 22:03:16 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	David Miller <davem@...emloft.net>
CC:	randy.dunlap@...cle.com, netdev@...r.kernel.org, jgarzik@...ox.com,
	alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH] net: hp-plus uses eip_poll

David Miller wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> Date: Tue, 25 Nov 2008 21:43:32 -0800
> 
>> David Miller wrote:
>>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>> Date: Tue, 25 Nov 2008 19:54:00 -0800
>>>
>>>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>>>
>>>> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
>>>>
>>>> drivers/built-in.o: In function `hpp_probe1':
>>>> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>>> I'll apply this to net-2.6
>>>
>>> But can you take a look at what I just pushed out to
>>> net-next-2.6 wrt. this driver and give me a hand untangling
>>> things there?
>>>
>>> Thanks a lot Randy!
>> Looks to me like both of this week's hp-plus patches (one to
>> drivers/net/Makefile & one to drivers/net/hp-plus.c) are
>> still needed there (unless you applied those patches but
>> didn't push or the push isn't showing up yet).
> 
> Ok.  I will need to merge.
> 
> But in net-next-2.6 that ->poll_controller is set in the
> hp-plus.c driver's netdev_ops structure.  That's what I
> wanted you to look at.

OK, it still uses ei_poll instead of eip_poll.
Needs to be changed.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html