netdev - Re: Question about HFSC atm+man patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <492F2A9B.2050903@ziu.info>
Date:	Fri, 28 Nov 2008 00:17:47 +0100
From:	Michal Soltys <nozo@....info>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: Question about HFSC atm+man patches

Patrick McHardy wrote:
> 
> Using different size tables for inner qdiscs is supposed to work. 
> What is the "wrong size"? ->peek() should return a packet with the 
> size the same as ->dequeue() would, which I think it does.
> 

That's not what I meant.

((struct qdisc_skb_cb*)skb->cb)->pkt_len

This is the value returned by qdisc_pkt_len() (now used whenever length 
is required, instead of skb->len), and it's recalculated during 
qdisc_calculate_pkt_len() called from qdisc_enqueue() - if a qdisc has 
stab. So the inner(most) qdisc with a size table, will be the last one 
setting that field.

Now, if an outer qdisc, e.g. HFSC, does peek() or dequeue() later, 
qdisc_pkt_len() will return overridden value.

If no qdiscs in "chain" have stab, then the field will be equal to 
skb->len - which is set in qdisc_enqueue_root() (otherwise uninitialzed 
value would be used later).

Am I seeing this right ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html