netdev - Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Nov 2008 10:43:19 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX
	stack

On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:

> +static inline __must_check
> +int wimax_dev_is_ready(struct wimax_dev *wimax_dev)
> +{
> +	if (wimax_dev->state == __WIMAX_ST_NULL)
> +		return -EINVAL;	/* Device is not even registered! */
> +	if (wimax_dev->state == WIMAX_ST_DOWN)
> +		return -ENOMEDIUM;

ENOLINK seems more appropriate?


> +/*
> + * The concept of a pipe -- we encapsulate it because we want to
> + * detach the usage of it from the implementation, and thus it serves
> + * just as a handle.

Might help to explain just what the concept is :)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)