netdev - atl1 transmit timeout Was: Re: oops/warning report for the week of November 26, 2008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081128151207.3999a097@osprey.hogchain.net>
Date:	Fri, 28 Nov 2008 15:12:07 -0600
From:	Jay Cliburn <jcliburn@...il.com>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	NetDev <netdev@...r.kernel.org>
Subject: atl1 transmit timeout Was: Re: oops/warning report for the week of
 November 26, 2008

On Fri, 28 Nov 2008 10:50:44 -0800
Arjan van de Ven <arjan@...ux.intel.com> wrote:

> => select count(version), version from oopses where
> guilty='dev_watchdog(atl1)' group by version order by version desc;
> count |     version -------+-----------------
>     93 | 2.6.27.5
>      6 | 2.6.27.4
>      1 | 2.6.27.3
>      1 | 2.6.27.2
>      1 | 2.6.27-rc9
>      1 | 2.6.27-rc7-git1
>      1 | 2.6.27-rc7
>      1 | 2.6.27-rc6
>      6 | 2.6.27-rc3
>      7 | 2.6.27
>      4 | 2.6.26.6
> (11 rows)

Wow.  4 hits in 2.6.26, then 118 in 2.6.27.

A history of changes between 2.6.26 and 2.6.27.5 shows a mere six
changes to the driver.

commit    event
======    =====
788a5f3f  2.6.27.5
8dc186c1  atl1: fix vlan tag regression
056c7145  2.6.27.4
322df44b  2.6.27.3
6bcd6d77  2.6.27.2
bc5b8bb6  2.6.27.1
3fa8749e  2.6.27
4330ed8e  2.6.27-rc9
94aca1da  2.6.27-rc8
72d31053  2.6.27-rc7
adee14b2  2.6.27-rc6
24342c34  2.6.27-rc5
82c26a9d  atl1: disable TSO by default
6a55617e  2.6.27-rc4
30a2f3c6  2.6.27-rc3
c2ac3ef3  atl1: deal with hardware rx checksum bug
0967d61e  2.6.27-rc2
6e86841d  2.6.27-rc1
39d48157  atl1: Do not wake queue before queue has been started.
b102df14  atl1: use netdev_alloc_skb
d63ddcec  misc drivers/net endianness noise
bce7f793  2.6.26

The only one that jumps out at me is 39d48157, which contains, in part:

commit 39d48157ac1a0ff3ec81212e5451bfd1bf5f50db
Author: David S. Miller <davem@...emloft.net>
Date:   Mon Jul 21 08:28:37 2008 -0700

    atl1: Do not wake queue before queue has been started.
    
    Based upon a bug report by Alexey Dobriyan, the patch is
    also tested by him and confirmed to fix the problem.
    
    Packet flow during link state events should not be done by
    waking and stopping the TX queue anyways, that is handled
    transparently by netif_carrier_{on,off}().
    
    So, remove the netif_{wake,stop}_queue() calls in the link
    check code, and add the necessary netif_start_queue() call
    to atl1_up().
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

[...]
@@ -2627,6 +2625,7 @@ static s32 atl1_up(struct atl1_adapter *adapter)
        mod_timer(&adapter->watchdog_timer, jiffies);
        atlx_irq_enable(adapter);
        atl1_check_link(adapter);
+       netif_start_queue(netdev);
        return 0;

Would it be reasonable to increase the above mod_timer() expiry to
jiffies + (5 * HZ)?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html