netdev - Re: [PATCH] [PPPOL2TP] Add missing sock_put() in pppol2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20081128.221322.67645422.davem@davemloft.net>
Date:	Fri, 28 Nov 2008 22:13:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	frederic.moulins@...atis.com
Cc:	jchapman@...alix.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] [PPPOL2TP] Add missing sock_put() in pppol2tp_release()

From: Frédéric Moulins <frederic.moulins@...atis.com>
Date: Thu, 27 Nov 2008 17:18:51 +0100

> pppol2tp_sock_to_session() do sock_hold() if the session to release is
> not NULL.
> 
> Signed-off-by: Frédéric Moulins <frederic.moulins@...atis.com>

Applied, but please post networking patches at least CC:'d to
netdev@...r.kernel.org so that your work gets properly tracked
at:

	http://patchwork.ozlabs.org/project/netdev/list

Thanks.

> ---
> Patch is applicable to kernels 2.6.26 and following.
> 
> Tested with a 2.6.26 stable kernel:
> without this patch, a session in a persistent tunnel cannot be
> established again (connect failed: -17), and the pppol2tp kernel module
> cannot be removed because still considered in use after stopping all
> userspace daemons.
> 
> diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
> index ff175e8..de80ba4 100644
> --- a/drivers/net/pppol2tp.c
> +++ b/drivers/net/pppol2tp.c
> @@ -1353,6 +1353,7 @@ static int pppol2tp_release(struct socket *sock)
>  			kfree_skb(skb);
>  			sock_put(sk);
>  		}
> +		sock_put(sk);
>  	}
>  
>  	release_sock(sk);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html