netdev - Re: [PATCH] phy: add suspend/resume into the PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081128.163604.31265829.davem@davemloft.net>
Date:	Fri, 28 Nov 2008 16:36:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] phy: add suspend/resume into the PHY drivers

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Thu, 27 Nov 2008 14:57:19 +0100

> almost all physical device drivers should be able to support power management.
> So this patch only adds the generic suspend/resume within them.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

An easier way to do this would be to check for a NULL suspend
and resume method at PHY register time, and assign the
genphy variants if so.

But first you would implement and hookup the exceptions so that they
would not appear NULL in this situation.

Could you please reimplement this patch that way?

Also, you have a driver in your tree which does not exist upstream,
drivers/net/phy/national.c, so this patch wouldn't apply correctly
anyways.

Always do your development against the current networking development
tree:

	master.kernel.org:/pub/scm/linux/kernel/git/davem/net-next-2.6.git
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html