lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Dec 2008 00:38:21 -0800 (PST) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: yjwei@...fujitsu.com, netdev@...r.kernel.org Subject: Re: [PATCH v4] xfrm: Fix kernel panic when flush and dump SPD entries From: Herbert Xu <herbert@...dor.apana.org.au> Date: Mon, 1 Dec 2008 16:11:11 +0800 > On Mon, Dec 01, 2008 at 03:50:54PM +0800, Wei Yongjun wrote: > > After flush the SPD entries, dump the SPD entries will cause kernel painc. > > > > Used the following commands to reproduct: > > > > - echo 'spdflush;' | setkey -c > > - echo 'spdadd 3ffe:501:ffff:ff01::/64 3ffe:501:ffff:ff04::/64 any -P out ipsec \ > > ah/tunnel/3ffe:501:ffff:ff00:200:ff:fe00:b0b0-3ffe:501:ffff:ff02:200:ff:fe00:a1a1/require;\ > > spddump;' | setkey -c > > - echo 'spdflush; spddump;' | setkey -c > > - echo 'spdadd 3ffe:501:ffff:ff01::/64 3ffe:501:ffff:ff04::/64 any -P out ipsec \ > > ah/tunnel/3ffe:501:ffff:ff00:200:ff:fe00:b0b0-3ffe:501:ffff:ff02:200:ff:fe00:a1a1/require;\ > > spddump;' | setkey -c > > > > This is because when flush the SPD entries, the SPD entry is not remove > > from the list. > > > > This patch fix the problem by remove the SPD entry from the list. And > > also do clean up of remove SPD entry. > > I like the clean-up but it's best if you separate the two changes > into two patches. That way it's easy to see exactly what the bug > fix patch is trying to fix and to verify that the clean-up patch > really doesn't change behaviour. Agreed. Wei, please do this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists