netdev - Re: [PATCH net-next] Phonet: basic net namespace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812011436.25064.remi.denis-courmont@nokia.com>
Date:	Mon, 1 Dec 2008 14:36:24 +0200
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext Denis V. Lunev" <den@...allels.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] Phonet: basic net namespace support

On Monday 01 December 2008 14:17:49 ext Denis V. Lunev, you wrote:
> On Mon, 2008-12-01 at 14:02 +0200, Rémi Denis-Courmont wrote:
> [snip]
>
> > -int phonet_address_lookup(u8 addr)
> > +int phonet_address_lookup(struct net *net, u8 addr)
> >  {
> >  	struct phonet_device *pnd;
> >
> >  	spin_lock_bh(&pndevs.lock);
> >  	list_for_each_entry(pnd, &pndevs.list, list) {
> > +		if (dev_net(pnd->netdev) != net)
> > +			continue;
>
> net_eq is better (noop without netns). also there are some similar
> places below

Ah ok, thanks for pointing it out. Here comes the two rewritten patches...

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html