netdev - Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081201185207.GB2379@uranus.ravnborg.org>
Date:	Mon, 1 Dec 2008 19:52:07 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
Cc:	Oliver Hartkopp <oliver@...tkopp.net>,
	David Miller <davem@...emloft.net>, Greg KH <greg@...ah.com>,
	Kurt Van Dijck <kurt.van.dijck@....be>,
	Linux Netdev List <netdev@...r.kernel.org>, stable@...nel.org
Subject: Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter

On Mon, Dec 01, 2008 at 07:42:31PM +0100, Oliver Hartkopp wrote:
> Sam Ravnborg wrote:
> >On Mon, Dec 01, 2008 at 05:15:42PM +0100, Oliver Hartkopp wrote:
> >  
> >>
> >>Thanks to Kurt Van Dijck for pointing at this issue and for the review.
> >>
> >>Signed-Off-by: Oliver Hartkopp <oliver@...tkopp.net>
> >>Acked-by: Kurt Van Dijck <kurt.van.dijck@....be>
> >>    
> >
> >If Kurt tested this patch then he should
> >be credited with a "Tested-by:" tag.
> >
> >I recall he did but I deleted the thread from my can mailbox.
> >
> >	Sam
> >  
> Hi Sam,
> 
> i did some testing and posted the results of a first patch that went 
> into the final direction.
> 
> In
> 
> https://lists.berlios.de/pipermail/socketcan-core/2008-December/002117.html
> 
> Kurt gave a "Reviewed-by:" and in a later mail in
> 
> https://lists.berlios.de/pipermail/socketcan-core/2008-December/002119.html
> 
> he wrote "my Acked-by: still stands" for the final patch.
> 
> So i choosed "Acked-by:".
> 
> As Kurt went that deep into the code that he pointed me to the right 
> line and presented a first idea for a patch, an 'Acked-by:' for 
> confirming the final patch looked like an appropriate credit to me.

OK and thanks for the clarification Oliver.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html