netdev - Re: net-next: lockdep complains re percpu counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081201.233748.204870635.davem@davemloft.net>
Date:	Mon, 01 Dec 2008 23:37:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	adobriyan@...il.com, netdev@...r.kernel.org
Subject: Re: net-next: lockdep complains re percpu counters

From: Eric Dumazet <dada1@...mosbay.com>
Date: Sun, 30 Nov 2008 17:36:56 +0100

> [PATCH] net: percpu_counter_inc() should not be called in BH-disabled section
> 
> I checked all per_cpu_counter_xxx() usages in network tree, and I think
> all call sites are BH enabled except one in inet_csk_listen_stop().
> 
> commit dd24c00191d5e4a1ae896aafe33c6b8095ab4bd1
> (net: Use a percpu_counter for orphan_count)
> replaced atomic_t orphan_count to a percpu_counter.
> 
> atomic_inc()/atomic_dec() can be called from any context, while percpu_counter_xxx()
> should be called from a consistent state.
> 
> For orphan_count, this context can be the BH-enabled one.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

I applied this preemptively even though Alexey hasn't given
test feedback yet, and I also added a mention of his report
in the commit message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html