lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 2 Dec 2008 00:19:20 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jeff@...zik.org" <jeff@...zik.org>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

On Mon, 1 Dec 2008, Stephen Hemminger wrote:

> On Mon, 01 Dec 2008 16:41:15 -0800
> Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> 
> > From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> > 
> > This patch implements the PCIe Advanced Error Reporting callbacks in
> > ixgbe.  The 82598 hardware supports AER, so we enable it.
> > 
> > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> 
> Once again: pcie-aer is not checking for mmconfig working!
> If you turn it on, you may get screaming errors.
> 
> pci_enable_pcie_error_reporting should be checking for pci_read/pci_write
> config errors and does not.
> 
> Your driver should be checking for pci_enable_pcie_error_reporting failing.

I'll respin and have a new patch sent for this.  I just finally saw the 
igb thread, so my apologies for missing this earlier.

Cheers,
-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists