lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 02 Dec 2008 15:11:26 +0100
From:	Claudio Lanconelli <lanconelli.claudio@...ar.com>
To:	Baruch Siach <baruch@...s.co.il>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] enc28j60: Fix sporadic packet loss

Baruch Siach wrote:
> +/*
> + * Calculate wrap arround when reading beyond the end of the RX buffer
                      ^
> + */
> +static u16 rx_packet_start(u16 ptr)
> +{
> +	if (ptr + RSV_SIZE > RXEND_INIT)
> +		return (ptr + RSV_SIZE) - (RXEND_INIT - RXSTART_INIT + 1);
> +	else
> +		return ptr;
> +}

should be
...
	else
		return ptr + RSV_SIZE;

With this change you can add the line
Acked-by: Claudio Lanconelli <lanconelli.claudio@...ar.com>


Cheers,
Claudio

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists