netdev - Re: [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Dec 2008 18:06:39 -0800
From:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 08/39] wimax: Mappping of generic netlink family IDs to net devices

On Thursday 27 November 2008, Johannes Berg wrote:
> On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:

> > +		}
> > +	}
> > +	d_printf(1, NULL, "wimax: no device associated to ID %d\n", id);
>
> remove debug statement (or make it depend on !wimax_dev)
>
> > +	wimax_dev = NULL;
> > +out_unlock:
> > +	spin_unlock(&wimax_id_table_lock);
> > +	d_fnend(3, NULL, "(info %p) = %p\n", info, wimax_dev);
> > +	return wimax_dev;
>
> No need for gotos any more :)

Duh ... sometimes the autopilot is not a good thing.

Fixed, thanks

-- 
Inaky

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html