netdev - RE: [PATCH next 1/2]e1000: e1000_adapter->polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A78C6259B11833419567082E2DC0C256BD9F307B@orsmsx508.amr.corp.intel.com>
Date:	Wed, 3 Dec 2008 14:44:44 -0800
From:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:	Wang Chen <wangchen@...fujitsu.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH next 1/2]e1000: e1000_adapter->polling_netdev is useless

>-----Original Message-----
>From: Wang Chen [mailto:wangchen@...fujitsu.com]
>Sent: Wednesday, December 03, 2008 4:58 AM
>To: David Miller
>Cc: Kirsher, Jeffrey T; netdev@...r.kernel.org
>Subject: [PATCH next 1/2]e1000: e1000_adapter->polling_netdev is useless
>
>David Miller said the following on 2008-12-3 7:06:
>> From: Wang Chen <wangchen@...fujitsu.com>
>> Date: Tue, 02 Dec 2008 21:33:09 +0800
>>
>>> e1000_adapter->polling_netdev is not actually used after allocated.
>>> So, my question is that is it useless?
>>
>> It's probably a leftover from before we added support for
>> multiqueue NAPI.
>>
>> Intel folks can probably confirm.
>
>Commit bea3348eef27e6044b6161fd04c3152215f96411
>"[NET]: Make NAPI polling independent of struct net_device objects."
>made NAPI polling to be independent of net_device.
>So e1000_adapter->polling_netdev is no longer used.
>Kill it.
>
>Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
>---
> drivers/net/e1000/e1000.h      |    1 -
> drivers/net/e1000/e1000_main.c |   27 +--------------------------
> 2 files changed, 1 insertions(+), 27 deletions(-)
>

Just to make sure that this does not break anything, I currently have this
patch in testing.

Cheers,
Jeff


Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (3098 bytes)